Eve of the Apocalypse: Twilight

Just kidding, its 1.12d.

DarnYak

Known bugs:
[FIXED]-Hero respawn is sometimes
[FIXED]-Talents don't work
[FIXED]-Bounty from hero kills appears for all players
-Spawn rates feel off
[FIXED]-Heroes get exp while dead

For those who had heroes not respawn: Did anyone (besides CokeMonkey in the Candleburg game) happen to research a strength upgrade while they were dead?

DarnYak

Update: Looks like that was it. If you want to play this test version, do not research strength while dead.

This actually leads to an interesting bug in general. The only way i know of to test if a unit is dead is to check if its health is <= 0. However, a strength research increases a dead hero's health past 0. Thus, everything starts thinking the hero is alive again. Which means the hero does shit like earn experience while dead (explaining the other bug).

DarnYak

Use IsUnitType(u,UNIT_TYPE_DEAD).

There are a lot of documented problems with checking a unit's life, starting with the fact that a unit can have more than .405 hit points and still be alive

Awesome, didn't know that existed.

DarnYak

War3 really is notorious for having poor death checks, I remember trying to code a number of abilities where it checked for dead units around a unit and half the time even if they were decaying corpses it wouldn't acknowledge them as dead yet.

What about setting the 'dead' unit/heroes HP regen to a negative upon 'death' so they will 'die' again properly? Or is that possible?

Strength also changes a unit's life regeneration rate...

It might be worth testing I suppose to change regen to -500 then back to 0 on respawn and see if it properly carries over strength

Btw, does anyone else feel spawn rates are off, or is it only me?

DarnYak

Anyone for more test games today?

Probably need more forewarning to get people to show up. If people do show up, make a post here to let me know and i'll join in.

DarnYak

Kalrithus wrote:Anyone for more test games today?

Any particular time?